Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation/comment issue in Konami 573 driver #9669

Closed
simzy39 opened this issue May 2, 2022 · 1 comment
Closed

Documentation/comment issue in Konami 573 driver #9669

simzy39 opened this issue May 2, 2022 · 1 comment

Comments

@simzy39
Copy link
Contributor

simzy39 commented May 2, 2022

This concerns some driver comments about the game Dance Dance Revolution Kids.

I apologise if this is wrong place to post this, but I cannot get MameTesteers login working for me.

In the Konami System 573 (https://github.com/mamedev/mame/blob/master/src/mame/drivers/ksys573.cpp)
it says: "? *Dance Dance Revolution Kids 2000.12

The * denotes undumped.

Anyway, the game has been dumped and doesn't run on this hardware. DDR Kids belong in, and is in,
the Konami GSAN1 driver (https://github.com/mamedev/mame/blob/master/src/mame/drivers/konamigs.cpp).

The GSAN1 driver also has a confusing line: ' * denotes these games are archived'
I'm not used to this since that * usually denotes undumped.
@cuavas
Copy link
Member

cuavas commented May 2, 2022

Surely you can open a pull request to remove one errant line?

There's no standard for formatting those lists in file header comments. You'll have to get used to then all being different.

@simzy39 simzy39 closed this as completed May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cuavas @simzy39