Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Static Code Analyzer : Error Handling : Overly Broad Catch #457

Closed
jmccausland opened this issue Oct 5, 2017 · 3 comments
Closed

Static Code Analyzer : Error Handling : Overly Broad Catch #457

jmccausland opened this issue Oct 5, 2017 · 3 comments
Labels
A-bug E-verified T-SCA
Milestone
APR 2018 Sprint 3

Comments

@jmccausland
Copy link
Collaborator

  • update code to only handle known exceptions
  • let the rest bubble up, remove catch(Exception ex)
@csmoore
Copy link
Member

csmoore commented Feb 15, 2018

There may be more to this issue once we see the report but as it is currently stated I'm not sure we want to do this one. It is basically saying to remove the exception handlers (and let crash?). @kgonzago @lfunkhouser

This was referenced Feb 19, 2018
Merged
Closed
@csmoore
Copy link
Member

csmoore commented Feb 19, 2018

Addressed in PR #502 and can be verified with #456 (see: #456 (comment)).

@ACueva
Copy link
Contributor

ACueva commented Feb 20, 2018

This has been verified. There are no longer any references to this build warning on the latest build.

@lfunkhouser lfunkhouser added this to the APR 2018 Sprint 3 milestone Feb 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-bug E-verified T-SCA
Projects
None yet
Milestone
APR 2018 Sprint 3
Development

No branches or pull requests
4 participants
@csmoore @ACueva @lfunkhouser @jmccausland